New feature Global DefaultStringComparisonIsCaseInsensitive

[moxplod]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes #191 and #193

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• I have performed a self-review of my code
• I have added tests that prove my fix is effective or that my feature works
• I have made corresponding changes to the documentation
• I have commented my code, particularly in hard-to-understand areas
• New and existing unit tests pass locally with my changes

[moxplod]

For this issue - #193

[moxplod]

Hey, regarding your other branch and refactors. Since I do not have context, do you want to modify this PR/branch directly and take over since my code changes here are pretty minimal?

I am happy to help where I can.

[alirezanet]

Hey, regarding your other branch and refactors. Since I do not have context, do you want to modify this PR/branch directly and take over since my code changes here are pretty minimal?

I am happy to help where I can.

Sure, would be nice if you could resolve the conflicts so I can use your branch.

[alirezanet]

I was thinking maybe If the default CaseInsensitiveFiltering is set to true, it would be logical to treat the /i operator as a case-sensitive operator instead. what do you think?

[moxplod]

Hey, regarding your other branch and refactors. Since I do not have context, do you want to modify this PR/branch directly and take over since my code changes here are pretty minimal?
I am happy to help where I can.

Sure, would be nice if you could resolve the conflicts so I can use your branch.

Doing that now. Thanks!

[moxplod]

I was thinking maybe If the default CaseInsensitiveFiltering is set to true, it would be logical to treat the /i operator as a case-sensitive operator instead. what do you think?

This makes sense to me as I am in the context of this change. We will have to explain this well in the documentation though as it may get slightly tricky for a new user.

[moxplod]

Conflicts resolved @alirezanet

[alirezanet]

This makes sense to me as I am in the context of this change. We will have to explain this well in the documentation though as it may get slightly tricky for a new user.

Yeah I agree. I'll try to update this branch with the required changes for now. Once everything is done, we can decide what changes are needed to the documentation and possibly come up with better configuration names to make it as self-explanatory as possible

[alirezanet]

Hello @moxplod,
I've merged my updates for issue 193 into this branch. It's shaping up well, but it requires additional testing. I've also inserted a TODO in the code for future support of the Like and NotLike operators, and possibly StartWith and EndWith. Currently, I'm quite occupied, so finalizing this might be delayed. If you're available, completing the implementation for the remaining operators and their testing would be our subsequent move.
also we need to test contains methods for non-string properties to make sure it is still working.

[moxplod]

Hey, @alirezanet, I got a pretty busy work week as well unfortunately.
I am not very fluent with the expression creation and the syntaxes there, so may take some time to understand the changes here :)

But, Thanks for this. I will try and get to it this week.

outdated

[alirezanet]

Hi @moxplod,
I think this is ready to merge, I hope I didn't miss anything... would be nice if you do a double check and review it again if you were happy with the new changes we can merge it

[moxplod]

This looks great! Thanks for getting it across the finish line.

[moxplod]

Looks great