Add credential provider support #253
Conversation
Adds an abstract credential provider class that can be used to programmatically supply credentials at authentication time, instead of just a static username and password.
|
Closes #246 |
There was a problem hiding this comment.
Generally this looks great! Thank you for the comprehensive and very clean contribution!
I've left a few minor suggestions for your consideration. Additionally if you have an implementation for an IAM provider for example - perhaps this could be added to coredis.recipes and referenced in the documentation?
* Added an IAM Elasticache credential provider example * Simplified some of the Credential provider implementation and usage
|
@alisaifee Thanks for the review! Let me know if there are any other changes you'd like me to make. |
Wow, amazing turnaround to address the suggestion! Thank you! Looks great to me. I wasn't able to verify the rendering of the docs since I've broken my local sphinx environment but that's a minor detail we can iron out in master. Regarding the typing issues in CI with respect to boto - feel free to add it to the ignore list. |
|
@alisaifee Hopefully that's the correct place to ignore them. Let me know if it's not. |
It is indeed. Needed a few tweaks to get past mypy. Since it's a recipe it's fine to be a bit relaxed on the type strictness IMO. |
Co-authored-by: Ali-Akber Saifee <ali@indydevs.org>
|
@trentbitterman unless you have anything else to add, I'll probably merge this once CI is done. |
|
That works for me, I didn’t have any other changes planned. Thanks! |
Adds an abstract credential provider class that can be used to programmatically supply credentials at authentication time, instead of just a static username and password.
Adds an abstract credential provider class that can be used to programmatically supply credentials at
authentication time, instead of just a static username and password.