Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(make): improve local cleanup and installation #24

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

alissonperez
Copy link
Owner

@alissonperez alissonperez commented Mar 14, 2024

What was done?

This PR improves the local cleanup and installation process. The changes include:

  • The cleanup command in the Makefile now also uninstalls the gpt-pr package.
  • The install command now runs cleanup and requirements before installing, and uses pip install . instead of python setup.py install.
  • A new version argument has been added to the run function in main.py, which prints the current version of the package.
  • A new version.py file has been added, which is automatically generated when the package is released and contains the current version.
  • The setup.py file now writes the current version to version.py when the package is installed.

How was it done?

The changes were made by modifying the Makefile and several Python files. The cleanup and install commands in the Makefile were updated to improve the cleanup and installation process. The run function in main.py was updated to add a new version argument. A new version.py file was added to store the current version of the package, and the setup.py file was updated to write the current version to this file.

How was it tested?

The changes were tested by running the updated cleanup and install commands and checking that they work as expected. The new version argument was tested by running the run function with this argument and checking that it prints the correct version. The new version.py file was tested by checking that it is correctly generated when the package is released and contains the correct version. The updated setup.py file was tested by installing the package and checking that it correctly writes the current version to version.py.

@alissonperez alissonperez merged commit 9598c50 into main Mar 14, 2024
2 checks passed
@alissonperez alissonperez deleted the feat/version branch March 14, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant