Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STARlight introduction in AliGenerators #5466

Merged
merged 3 commits into from
May 14, 2024
Merged

STARlight introduction in AliGenerators #5466

merged 3 commits into from
May 14, 2024

Conversation

jackal1-66
Copy link
Contributor

Added STARlight dependency to AliGenerators. STARlight recipe has been edited to pull directly the main branch from the official STARlight repository. In addition the HepMC3 package has been set as a dependency and STARlight is now built with it, so that it could also be useful for RIVET analyses. Tests performed locally are encouraging.

Added STARlight dependency to AliGenerators. STARlight recipe has been edited to pull directly the main branch from the official STARlight repository. In addition the HepMC3 package has been set as a dependency and STARlight is now built with it, so that it could also be useful for RIVET analyses. Tests performed locally are encouraging.
@jackal1-66 jackal1-66 requested review from a team as code owners May 13, 2024 20:19
@jackal1-66
Copy link
Contributor Author

@ktf the error on alidist seems unrelated to the introduction of STARlight. Could you please check?

starlight.sh Outdated Show resolved Hide resolved
@ktf
Copy link
Member

ktf commented May 14, 2024

Fine with me. Just fix up the quotes and then I will merge.

@jackal1-66
Copy link
Contributor Author

Fine with me. Just fix up the quotes and then I will merge.

I added the double quotes and noticed there was HepMC2 instead of 3. It was working anyway, but better upgrade that little part as well. Tested locally and it works.

starlight.sh Outdated Show resolved Hide resolved
@ktf
Copy link
Member

ktf commented May 14, 2024

Thanks! Could you please use a tagged version as well?

I also noticed the recipe generates its own modulefile. It's probably better to move to use alibuild-generate-module so that eventual runtime dependencies are taken into account. Grep for it in alidist to see how it's used elsewhere.

@ktf
Copy link
Member

ktf commented May 14, 2024

(the last point can be done in a separate PR, if you prefer)

@jackal1-66
Copy link
Contributor Author

Thanks! Could you please use a tagged version as well?

I also noticed the recipe generates its own modulefile. It's probably better to move to use alibuild-generate-module so that eventual runtime dependencies are taken into account. Grep for it in alidist to see how it's used elsewhere.

I will move to alibuild-generate-module on a different PR. I prefere being sure that everything works as expected before moving to that (minimum changes at a time).

@ktf
Copy link
Member

ktf commented May 14, 2024

Thank you for the fixes. Let's have a last spin on the AliGenerators test and then I will merge.

@jackal1-66
Copy link
Contributor Author

build/O2/alidist-dataflow-cs8 failing is unrelated to this PR

@jackal1-66
Copy link
Contributor Author

The current alidist failures are not related to this PR.

@ktf ktf merged commit 8a3ccc1 into alisw:master May 14, 2024
11 of 15 checks passed
@jackal1-66 jackal1-66 deleted the AliSTARlight branch May 14, 2024 17:59
chiarazampolli pushed a commit that referenced this pull request Sep 6, 2024
Added STARlight dependency to AliGenerators. STARlight recipe has been edited to pull directly the main branch from the official STARlight repository. In addition the HepMC3 package has been set as a dependency and STARlight is now built with it, so that it could also be useful for RIVET analyses. Tests performed locally are encouraging.

(cherry picked from commit 8a3ccc1)
@chiarazampolli
Copy link
Collaborator

Ported to async-v1-01-03, label removed.

MichaelLettrich pushed a commit to MichaelLettrich/alidist that referenced this pull request Oct 3, 2024
Added STARlight dependency to AliGenerators. STARlight recipe has been edited to pull directly the main branch from the official STARlight repository. In addition the HepMC3 package has been set as a dependency and STARlight is now built with it, so that it could also be useful for RIVET analyses. Tests performed locally are encouraging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants