-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STARlight introduction in AliGenerators #5466
Conversation
Added STARlight dependency to AliGenerators. STARlight recipe has been edited to pull directly the main branch from the official STARlight repository. In addition the HepMC3 package has been set as a dependency and STARlight is now built with it, so that it could also be useful for RIVET analyses. Tests performed locally are encouraging.
@ktf the error on alidist seems unrelated to the introduction of STARlight. Could you please check? |
Fine with me. Just fix up the quotes and then I will merge. |
I added the double quotes and noticed there was HepMC2 instead of 3. It was working anyway, but better upgrade that little part as well. Tested locally and it works. |
Thanks! Could you please use a tagged version as well? I also noticed the recipe generates its own modulefile. It's probably better to move to use |
(the last point can be done in a separate PR, if you prefer) |
I will move to alibuild-generate-module on a different PR. I prefere being sure that everything works as expected before moving to that (minimum changes at a time). |
Thank you for the fixes. Let's have a last spin on the AliGenerators test and then I will merge. |
build/O2/alidist-dataflow-cs8 failing is unrelated to this PR |
The current alidist failures are not related to this PR. |
Added STARlight dependency to AliGenerators. STARlight recipe has been edited to pull directly the main branch from the official STARlight repository. In addition the HepMC3 package has been set as a dependency and STARlight is now built with it, so that it could also be useful for RIVET analyses. Tests performed locally are encouraging. (cherry picked from commit 8a3ccc1)
Ported to async-v1-01-03, label removed. |
Added STARlight dependency to AliGenerators. STARlight recipe has been edited to pull directly the main branch from the official STARlight repository. In addition the HepMC3 package has been set as a dependency and STARlight is now built with it, so that it could also be useful for RIVET analyses. Tests performed locally are encouraging.
Added STARlight dependency to AliGenerators. STARlight recipe has been edited to pull directly the main branch from the official STARlight repository. In addition the HepMC3 package has been set as a dependency and STARlight is now built with it, so that it could also be useful for RIVET analyses. Tests performed locally are encouraging.