Fixed write to closed channel in dispatcher #87
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dispatcher may panic with
send on closed channel
when pool is closing while new jobs are being added.Write
tries to send onbufferHasElements
, which may be being closed inClose()
at the same moment. To avoid that, I decided to never closebufferHasElements
which may seem dirty, but should work fine sincebufferHasElements
will be removed by GC anyway.I added test case to reproduce the issue as well.