fix: resolve String() npe bug of response when response is empty

aliyun · Aug 21, 2023 · 3c96299 · 3c96299
1 parent 38368f2
commit 3c96299
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/sdk/responses/response.go b/sdk/responses/response.go
@@ -120,16 +120,22 @@ func (baseResponse *BaseResponse) String() string {
 	resultBuilder := bytes.Buffer{}
 	// statusCode
 	// resultBuilder.WriteString("\n")
-	resultBuilder.WriteString(fmt.Sprintf("%s %s\n", baseResponse.originHttpResponse.Proto, baseResponse.originHttpResponse.Status))
+	if baseResponse.originHttpResponse != nil {
+		resultBuilder.WriteString(fmt.Sprintf("%s %s\n", baseResponse.originHttpResponse.Proto, baseResponse.originHttpResponse.Status))
+	}
 	// httpHeaders
 	//resultBuilder.WriteString("Headers:\n")
-	for key, value := range baseResponse.httpHeaders {
-		resultBuilder.WriteString(key + ": " + strings.Join(value, ";") + "\n")
+	if baseResponse.httpHeaders != nil {
+		for key, value := range baseResponse.httpHeaders {
+			resultBuilder.WriteString(key + ": " + strings.Join(value, ";") + "\n")
+		}
+		resultBuilder.WriteString("\n")
 	}
-	resultBuilder.WriteString("\n")
+
 	// content
 	//resultBuilder.WriteString("Content:\n")
 	resultBuilder.WriteString(baseResponse.httpContentString + "\n")
+
 	return resultBuilder.String()
 }
 

diff --git a/sdk/responses/response_test.go b/sdk/responses/response_test.go
@@ -39,6 +39,8 @@ func Test_CommonResponse(t *testing.T) {
 
 func Test_CommonResponse_parseFromHttpResponse(t *testing.T) {
 	r := NewCommonResponse()
+	assert.Equal(t, "\n", r.String())
+
 	res := makeHTTPResponse(200, "")
 	res.Header.Add("Server", "GitHub.com")
 	r.parseFromHttpResponse(res)