Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix acs_request.go map in struct request #597

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

King-Hell
Copy link

ECI团队提交:增加对于struct嵌套map格式request的支持,用以支持ECI DataCache API上线

@CLAassistant
Copy link

CLAassistant commented Jul 5, 2023

CLA assistant check
All committers have signed the CLA.

@JacksonTian JacksonTian temporarily deployed to ci September 27, 2023 02:34 — with GitHub Actions Inactive
@JacksonTian JacksonTian temporarily deployed to ci September 27, 2023 02:34 — with GitHub Actions Inactive
@JacksonTian JacksonTian temporarily deployed to ci September 27, 2023 05:41 — with GitHub Actions Inactive
@JacksonTian JacksonTian temporarily deployed to ci September 27, 2023 05:41 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Merging #597 (da51ff3) into master (9a572a8) will decrease coverage by 0.34%.
The diff coverage is 0.00%.

❗ Current head da51ff3 differs from pull request most recent head 03607a3. Consider uploading reports for the commit 03607a3 to get more accurate results

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
- Coverage   93.57%   93.24%   -0.34%     
==========================================
  Files          48       48              
  Lines        2538     2547       +9     
==========================================
  Hits         2375     2375              
- Misses        106      114       +8     
- Partials       57       58       +1     
Files Coverage Δ
sdk/requests/acs_request.go 78.11% <0.00%> (-2.75%) ⬇️

@JacksonTian
Copy link
Contributor

@King-Hell 需要一个单元测试来覆盖这部分代码。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants