add query for client #220
Merged
add query for client #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
weilong.pwl seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
added 2 commits
August 11, 2023 16:00
panawala
force-pushed
the
feature/add_query_for_client
branch
from
b258497
to
c828333
Compare
tangkai1719
reviewed
Aug 14, 2023
log_store.go
Outdated
| uri += fmt.Sprintf("&end_cursor=%v", plr.EndCursor) | ||
| } | ||
| if plr.Query != "" { | ||
| uri += fmt.Sprintf("&query=%v", plr.Query) |
There was a problem hiding this comment.
裸拼字符串query字段可能有问题，建议整体做一下escape
client_interface.go
Outdated
| // PullLogs gets logs from shard specified by shardId according cursor and endCursor. | ||
| // The logGroupMaxCount is the max number of logGroup could be returned. | ||
| // The nextCursor is the next cursor can be used to read logs at next time. | ||
| // @note if you want to pull logs continuous, set endCursor = "" | ||
| PullLogs(project, logstore string, shardID int, cursor, endCursor string, | ||
| logGroupMaxCount int) (gl *LogGroupList, nextCursor string, err error) | ||
| PullLogsWithQuery(plr *PullLogRequest) (gl *LogGroupList, nextCursor string, err error) |
There was a problem hiding this comment.
我想这个common的方法可以改个名字：PullLogsV2之类的？不要过于突出 Query（一些用户用不到这个功能，反而会多问）
There was a problem hiding this comment.
已改为PullLogsV2，PullLogRequest放到了model.go里面
tangkai1719
approved these changes
Aug 14, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.