Feat cgo-zstd #284
Merged
Feat cgo-zstd #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liketic
reviewed
Jun 17, 2024
liketic
reviewed
Jun 17, 2024
compressor.go
Outdated
| "github.com/klauspost/compress/zstd" | ||
| ) | ||
|
|
||
| var DefaultZstdCompressor LogCompressor = NewZstdCompressor(zstd.SpeedFastest) |
There was a problem hiding this comment.
DefaultZstdCompressor，这个名称是 Default，是允许修改吗？直接是 ZstdCompressor 是不是好点
There was a problem hiding this comment.
compressLevel := 1
sls.DefaultZstdCompressor = cgozstd.NewZstdCompressor(compressLevel)
There was a problem hiding this comment.
DefaultZstdCompressor =》ZstdCompressor
There was a problem hiding this comment.
或者，能不能搞一个函数
sls.SetZstdCgoCompressor(compressLevel int)
这样里面随便我们怎么改，只要接口在就行
liketic
requested changes
Jul 30, 2024
compressor.go
Outdated
| "github.com/klauspost/compress/zstd" | ||
| ) | ||
|
|
||
| var DefaultZstdCompressor LogCompressor = NewZstdCompressor(zstd.SpeedFastest) |
There was a problem hiding this comment.
DefaultZstdCompressor =》ZstdCompressor
extensions/cgo-zstd/README.md
Outdated
| @@ -0,0 +1,81 @@ | |||
| ## 介绍 | |||
| cgo-zstd 是基于 cgo 实现的 zstd 压缩库，比纯 go 实现的 zstd 在性能上具有一定优势。 | |||
There was a problem hiding this comment.
我在想，能不能就搞一个 internal/zstd_cgo.go 这样一个文件。我们还有什么内容是需要放到这里的？
liketic
reviewed
Jul 31, 2024
cgo/README.md
Outdated
| @@ -0,0 +1,81 @@ | |||
| ## 介绍 | |||
| cgo-zstd 是基于 cgo 实现的 zstd 压缩库，比纯 go 实现的 zstd 在性能上具有一定优势。 | |||
| 下面介绍如何开启此扩展来提升 zstd 压缩的性能。 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.