adding subfolder homepage types to IndexDocument #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Just realized there's another open PR addressing this: #265. Feel free to close this if you'd rather merge that instead. |
kkuai
force-pushed
the
master
branch
2 times, most recently
from
07f0838 to
3dce9c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in the API options necessary to enable and configure the Subfolder Homepage options for static websites on OSS. These options don't seem to be documented anywhere in the API docs, but you can see the options in the Alicloud OSS UI, and if you look at the XML responses from the API you'll see they exist. I had to reverse-engineer how this works; This should be added to the API docs.
Without adding these options, every time
SetBucketWebsiteDetailis called it just deletes the subfolder homepage settings on the OSS bucket.