Use https by default for endpoint #273
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using https by default is one of the security best practice rules nowadays. Azure also have been using https by default, you can refer to https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py With this changes, the existing programs of customers might fail with `CERTIFICATE_VERIFY_FAILED` if they didn't specify "http://" explicitly. To avoid surprise from customers, please notify developers and customers in Aliyun community and guides before merge/release with this changes.
|
|
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
httpsby default is one of the security best practice rules nowadays.Azure also have been using https by default, you can refer to _blob_client.py
Especially, the same function
_normalize_endpointindjango-oss-storagealso have been updated to usehttpsby default, you can refer to django-oss-storage codeWith this changes, the existing programs of customers might fail with
CERTIFICATE_VERIFY_FAILEDif they didn't specifyhttp://explicitly.To avoid surprise from customers, should broadcast developers and customers in Aliyun community and relevant developer blogs before this changes.