fix: should consume the response stream on error #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead-horse
reviewed
Jul 16, 2018
| @@ -264,6 +267,12 @@ proto.createRequest = function createRequest(params) { | |||
| customResponse: params.customResponse, | |||
| ctx: params.ctx || this.ctx, | |||
| }; | |||
| if (this.agent) { | |||
dead-horse
approved these changes
Jul 16, 2018
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 3 3
Lines 106 106
Branches 30 30
=======================================
Hits 102 102
Misses 4 4Continue to review full report at Codecov.
|
fengmk2
force-pushed
the
fix-consume-stream-on-error
branch
from
38cad2b
to
ad5d128
Compare
|
backport to 5.x #504 |
fengmk2
added a commit
that referenced
this pull request
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.