Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/alicloud_ess_scalinggroups: add attributes of stop_instance_timeout, scaling_policy, enable_desired_capacity, monitor_group_id, system_suspended, removing_capacity, pending_capacity, stopped_capacity, spot_capacity, standby_capacity, protected_capacity, removing_wait_capacity, pending_wait_capacity, init_capacity, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance. #8091

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

data-source/alicloud_ess_scalinggroups: add attributes of stop_instance_timeout, scaling_policy, enable_desired_capacity, monitor_group_id, system_suspended, removing_capacity, pending_capacity, stopped_capacity, spot_capacity, standby_capacity, protected_capacity, removing_wait_capacity, pending_wait_capacity, init_capacity, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance. #8091

wants to merge 1 commit into from
+859 −428

Conversation

fuliu-zln
Copy link
Contributor

No description provided.

@fuliu-zln fuliu-zln changed the title Feat/data dev data_source/alicloud_ess_scalinggroup: add attributes of stop_instance_timeout, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance. Jan 7, 2025
@fuliu-zln fuliu-zln changed the title data_source/alicloud_ess_scalinggroup: add attributes of stop_instance_timeout, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance. data-source/alicloud_ess_scalinggroup: add attributes of stop_instance_timeout, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance. Jan 7, 2025
@fuliu-zln fuliu-zln changed the title data-source/alicloud_ess_scalinggroup: add attributes of stop_instance_timeout, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance. data_source/alicloud_ess_scalinggroup: add attributes of stop_instance_timeout, scaling_policy, enable_desired_capacity, monitor_group_id, system_suspended, removing_capacity, pending_capacity, stopped_capacity, spot_capacity, standby_capacity, protected_capacity, removing_wait_capacpending_wait_capacity, init_capacity, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance. Jan 8, 2025
@fuliu-zln fuliu-zln changed the title data_source/alicloud_ess_scalinggroup: add attributes of stop_instance_timeout, scaling_policy, enable_desired_capacity, monitor_group_id, system_suspended, removing_capacity, pending_capacity, stopped_capacity, spot_capacity, standby_capacity, protected_capacity, removing_wait_capacpending_wait_capacity, init_capacity, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance. data-source/alicloud_ess_scalinggroup: add attributes of stop_instance_timeout, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance. Jan 8, 2025
@fuliu-zln fuliu-zln changed the title data-source/alicloud_ess_scalinggroup: add attributes of stop_instance_timeout, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance. data-source/alicloud_ess_scalinggroups: add attributes of stop_instance_timeout, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance. Jan 8, 2025
@fuliu-zln fuliu-zln changed the title data-source/alicloud_ess_scalinggroups: add attributes of stop_instance_timeout, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance. data-source/alicloud_ess_scaling_groups: add attributes of stop_instance_timeout, scaling_policy, enable_desired_capacity, monitor_group_id, system_suspended, removing_capacity, pending_capacity, stopped_capacity, spot_capacity, standby_capacity, protected_capacity, removing_wait_capacity, pending_wait_capacity, init_capacity, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance. Jan 8, 2025
@fuliu-zln fuliu-zln changed the title data-source/alicloud_ess_scaling_groups: add attributes of stop_instance_timeout, scaling_policy, enable_desired_capacity, monitor_group_id, system_suspended, removing_capacity, pending_capacity, stopped_capacity, spot_capacity, standby_capacity, protected_capacity, removing_wait_capacity, pending_wait_capacity, init_capacity, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance. New Data Source: alicloud_ess_scaling_groups Jan 8, 2025
@fuliu-zln fuliu-zln force-pushed the feat/dataDev branch 3 times, most recently from 522f201 to f00c842 Compare January 8, 2025 07:59
@MrWolong
Copy link
Collaborator

MrWolong commented Jan 9, 2025

标题改了，这个pr主要是新增出参字段，不是新数据源的接入，alicloud_ess_scaling_groups是在1.39.0版本接入的。如果旧资源，数据源文档中没有标记可用版本，就去CHANGELOG文件里面去找

MrWolong
MrWolong reviewed Jan 9, 2025
View reviewed changes
alicloud/data_source_alicloud_ess_scaling_groups.go
@@ -0,0 +1,488 @@
package alicloud
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么删除alicloud/data_source_alicloud_ess_scalinggroups.go和alicloud/data_source_alicloud_ess_scalinggroups_test.go文件

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci check导致的

MrWolong
MrWolong reviewed Jan 9, 2025
View reviewed changes
alicloud/data_source_alicloud_ess_scaling_groups.go Outdated
"github.com/hashicorp/terraform-plugin-sdk/helper/validation"
)

func dataSourceAlicloudEssScalingGroups() *schema.Resource {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alicloud全局替换为AliCloud

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@fuliu-zln fuliu-zln changed the title New Data Source: alicloud_ess_scaling_groups data-source/alicloud_ess_scaling_groups: add attributes of stop_instance_timeout, scaling_policy, enable_desired_capacity, monitor_group_id, system_suspended, removing_capacity, pending_capacity, stopped_capacity, spot_capacity, standby_capacity, protected_capacity, removing_wait_capacity, pending_wait_capacity, init_capacity, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance. Jan 9, 2025
@fuliu-zln fuliu-zln changed the title data-source/alicloud_ess_scaling_groups: add attributes of stop_instance_timeout, scaling_policy, enable_desired_capacity, monitor_group_id, system_suspended, removing_capacity, pending_capacity, stopped_capacity, spot_capacity, standby_capacity, protected_capacity, removing_wait_capacity, pending_wait_capacity, init_capacity, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance. data-source/alicloud_ess_scalinggroups: add attributes of stop_instance_timeout, scaling_policy, enable_desired_capacity, monitor_group_id, system_suspended, removing_capacity, pending_capacity, stopped_capacity, spot_capacity, standby_capacity, protected_capacity, removing_wait_capacity, pending_wait_capacity, init_capacity, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance. Jan 9, 2025
@fuliu-zln
data-source/alicloud_ess_scalinggroups: add attributes of stop_instan…
050ca65 
…ce_timeout, scaling_policy, enable_desired_capacity, monitor_group_id, system_suspended, removing_capacity, pending_capacity, stopped_capacity, spot_capacity, standby_capacity, protected_capacity, removing_wait_capacity, pending_wait_capacity, init_capacity, desired_capacity, max_instance_lifetime, multi_az_policy, group_type, resource_group_id, spot_instance_remedy, spot_instance_pools, on_demand_percentage_above_base_capacity, on_demand_base_capacity, spot_allocation_strategy, allocation_strategy and az_balance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrWolong MrWolong MrWolong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuliu-zln @MrWolong