Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alt text to emoji #42

Merged
merged 3 commits into from
Apr 15, 2017
Merged

Add alt text to emoji #42

merged 3 commits into from
Apr 15, 2017

Conversation

kevinjalbert
Copy link
Contributor

Fixes all-contributors/all-contributors#16

Using markdown its possible to attach an alt text (really the title attribute) on a link, where the value of the link is the the emoji. As for the actual href, using #xxxxx lets you not mess with the navigation assuming you have unique keys. In my example, I'm simply using the emoji's key and github user name (i.e., <emoji-username>).

All emojis are links even if they don't have any real url attached.

For example, [👀](#eyes-kevinjalbert "Reviewed Pull Requests")


  • Updated README with new changes
  • Added self to contributor list

Using markdown its possible to attach an alt text (really the title
attribute) on a link, where the value of the link is the the emoji. As
for the actual href, using #xxxxx lets you not mess with the navigation
assuming you have unique keys. In my example, I'm simply using the
emoji's key and github user name (i.e., `<emoji-username>`).

All emojis are links even if they don't have any real url attached.

For example, `[:eyes:](#eyes-kevinjalbert "Reviewed Pull Requests")`
Copy link
Collaborator

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! What do you think @jfmengels?

@jfmengels jfmengels merged commit f99b470 into all-contributors:master Apr 15, 2017
@jfmengels
Copy link
Collaborator

This looks awesome, thanks a lot @kevinjalbert. I love this because it makes contributions much clearer.

Berkmann18 pushed a commit that referenced this pull request May 24, 2020
* docs: document requirements for initial setup

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants