Control the start of event reporting for expiring certificates #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue summary
In cases where users install certificates of short duration, kubernetes events are spammed with multiple warnings of certificate expiry. This is undesirable. A means on reducing the number of warnings produced is more desirable.
See minio#1791
in the tenant crd,
.spec.certExpiryAlertThreshold
represents the minimum number of days to expiry before an alert for an expiring certificate is fired.For example considering
.spec.certExpiryAlertThreshold = 1
, if a given certificate will expire in 7 days then expiration events will only be triggered 1 day before expiryTest summary
certExpiryAlertThreshold
e.g.Verbose tests here:
https://github.com/allanrogerr/public/wiki/operator%E2%80%901791
Fixes: