Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control the start of event reporting for expiring certificates #52

Closed
wants to merge 1 commit into from

Conversation

allanrogerr
Copy link
Owner

@allanrogerr allanrogerr commented Jul 22, 2024

Issue summary

In cases where users install certificates of short duration, kubernetes events are spammed with multiple warnings of certificate expiry. This is undesirable. A means on reducing the number of warnings produced is more desirable.
See minio#1791
in the tenant crd, .spec.certExpiryAlertThreshold represents the minimum number of days to expiry before an alert for an expiring certificate is fired.
For example considering .spec.certExpiryAlertThreshold = 1, if a given certificate will expire in 7 days then expiration events will only be triggered 1 day before expiry

Test summary

  1. Build and install the minio operator
  2. Apply a tenant with Helm or Kustomize
  3. Create expired and expiring certificates
  4. Create secrets based on these
  5. Apply the secrets as external certificates
  6. Experiment with different values of certExpiryAlertThreshold e.g.
  7. Observe
  • if certExpiryAlertThreshold is not present then all certificate expiry events are reported
  • if the whole number of days left for a certificate to expire is less than certExpiryAlertThreshold then this certificate expiry events are reported
  • if the whole number of days left for a certificate to expire is greater than or equal to certExpiryAlertThreshold then this certificate expiry events are not reported

Verbose tests here:
https://github.com/allanrogerr/public/wiki/operator%E2%80%901791

Fixes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant