Fixes #193 - use git describe istead of listing tags #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgalek
reviewed
Jul 11, 2024
| @@ -5,8 +5,7 @@ module.exports = { | |||
| * Returns latest tag, sorted by version or null if no tag was found | |||
| */ | |||
| getLatestTag: (prefix) => { | |||
| const maybeGrepCommand = prefix !== '' ? `| grep "^${prefix}"` : ''; | |||
| const stdout = exec(`git tag -l ${maybeGrepCommand} | sort -V | tail -n 1`); | |||
| const stdout = exec(`git describe --match="${prefix}*"`); | |||
There was a problem hiding this comment.
We've been there:
I don't remember why did we got back to tag -l, until we find out why, I'm not ok with this change
bgalek
requested changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #193