Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional empty commit on release #18

Closed
szpak opened this issue Nov 20, 2014 · 5 comments
Closed

Optional empty commit on release #18

szpak opened this issue Nov 20, 2014 · 5 comments
Assignees
Milestone

Comments

@szpak
Copy link
Contributor

szpak commented Nov 20, 2014

It is great that axion doesn't depend on a version kept in a file, but it can be harder to notice a release just browsing commits (as tags are treated separately). There is a releases/tags tab in a GitHub interface, but sometimes it would be desirable to have a commit.

For those cases there could be a switch (disabled by default) which would make an empty commit with a message about release first and then tag it (there could be required an additional switch to allow JGit to accept empty commit).

@adamdubiel adamdubiel self-assigned this Nov 20, 2014
@adamdubiel adamdubiel added this to the 1.0.0 milestone Nov 20, 2014
@adamdubiel
Copy link
Collaborator

Nice feature, i would probably go with some configurable message template (like "release: $tag") instead of empty commit.

@adamdubiel adamdubiel modified the milestones: 0.9.5, 1.0.0 Nov 20, 2014
@szpak
Copy link
Contributor Author

szpak commented Nov 20, 2014

Yes, I also thought about a message (nice to have it configurable), but I don't know what files could be modified and because of that it wrote "an empty commit".

@adamdubiel
Copy link
Collaborator

Ah, i see. There is no problem with empty commits (used in tests).

@adamdubiel
Copy link
Collaborator

Done, you can see readme on development branch to see how it will be configurable.

@szpak
Copy link
Contributor Author

szpak commented Nov 24, 2014

Looks good for me, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants