Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non-semver tags #830

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Ignore non-semver tags #830

merged 1 commit into from
Oct 14, 2024

Conversation

radoslaw-panuszewski
Copy link
Collaborator

@radoslaw-panuszewski radoslaw-panuszewski commented Oct 4, 2024

I'm not sure if it's worth to hide this behavior under a config property - the only difference is that the plugin won't fail in some cases and just ignore the non-semver tags

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.74%. Comparing base (62dc4af) to head (eae62d5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #830   +/-   ##
=========================================
  Coverage     63.74%   63.74%           
  Complexity      442      442           
=========================================
  Files            82       82           
  Lines          1633     1633           
  Branches        161      161           
=========================================
  Hits           1041     1041           
  Misses          523      523           
  Partials         69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radoslaw-panuszewski radoslaw-panuszewski marked this pull request as ready for review October 14, 2024 15:09
@bgalek bgalek merged commit 8dd9708 into main Oct 14, 2024
4 checks passed
@vladimirfx
Copy link

In which cases this should work?

Example:

Prefix: mfc-backend
Latest tag: mfc-backend-5.21.1
Old tag (6 year old): mfc-backend-core-2.44.1

Error:

❯ ./gradlew cV

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'mfc-backend'.
> Failed to parse version: mfc-backend-core-2.44.1 that matched configured prefix: mfc-backend. There can be no tags that match the prefix but contain non-SemVer string after the prefix. Detailed message: Unexpected character 'LETTER(c)' at position '0', expecting '[DIGIT]'

I can't use that prefix because 6 years ago the module name was longer. It will be cool if incorrect tags are just ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants