Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the compilation jdk from 11 to 17 #854

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lakhwinderr
Copy link

Hi, I am beginner to this tech stack. As per my knowledge, I changed the JDK version to 17. Do let me know other changes to make.

@solonovamax
Copy link

What is the benefit of this?

Currently, gradle supports jdk 8-23, and support for jdks 8-16 will not be dropped until gradle 9.0 is released.
You are able to run the plugin just fine when using a jdk ≥11 for gradle, currently.

@Zordid
Copy link

Zordid commented Feb 7, 2025

Also don't see the point in such a PR...

@bgalek
Copy link
Member

bgalek commented Feb 9, 2025

Someday people need to migrate to later JDK's anyway ;)
I'm going to switch to JDK21 for sure, but I'll leave compilation target to JDK11 for now

@Zordid
Copy link

Zordid commented Feb 9, 2025

I meant in such a tiny PR with changing a number. No other changes, no tests and also stating he's a beginner. I would not trust in that he knows the consequences of changing this for a product used by many. He did not even adjust the README.md to reflect what he did. So, I stand with my comment. What's the point in doing such a PR? Did he think nobody else was able to change that number before?

@bgalek
Copy link
Member

bgalek commented Feb 9, 2025

@Zordid it was hacktoberfest contribution, i should have made a better issue description, it's on me

@solonovamax
Copy link

Someday people need to migrate to later JDK's anyway ;)
I'm going to switch to JDK21 for sure, but I'll leave compilation target to JDK11 for now

you should keep targeting jdk 8 until gradle 9 is released, at which point the minimum gradle jdk will be bumped from 8 to 17 (see: https://gradle.org/whats-new/gradle-9/)

sometimes it is still necessary to run gradle with a java 8 jdk, so support for it should not be dropped unless absolutely necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants