Update readme to version 3 #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had some memory leaks in production. after further investigations, we found out that we were using big cache v1 (which interestingly HardMaxCacheSize is not working properly). I'm sure if we don't change it to version 2 it will cause some confusion.
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
=======================================
Coverage 86.56% 86.56%
=======================================
Files 15 15
Lines 640 640
=======================================
Hits 554 554
Misses 71 71
Partials 15 15 Continue to review full report at Codecov.
|
|
We already have V3 |
cristaloleg
approved these changes
Feb 27, 2021
janisz
approved these changes
Mar 1, 2021
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some memory leaks in production. after further investigations, we found out that we were using big cache v1 (which interestingly HardMaxCacheSize is not working properly). I'm sure if we don't change it to version 2 it will cause some confusion.