Blacklisted Healthcheck types

[dankraw]

Introducing consul-ignored-healthchecks configuration property which allows one to ignore specified types of Marathon health checks during service registration in Consul.

Fixes #118

[coveralls]

Coverage increased (+0.2%) to 79.276% when pulling a1b6468 on blacklisted-healthcheck-types into f4d4a70 on develop.

[janisz]

How about something like this:

ignoredTypes := strings.Split(strings.ToUpper(c.config.IgnoredHealthChecks), ","))

[dankraw]

OK, I've fixed it so ToUpper is called once, but still I'd like to check if the input is valid (trim, remove empty values):

ignoredTypes := make([]string, 0)
    for _, ignoredType := range strings.Split(strings.ToUpper(c.config.IgnoredHealthChecks), ",") {
        var ignoredType = strings.TrimSpace(ignoredType)
        if ignoredType != "" {
            ignoredTypes = append(ignoredTypes, ignoredType)
        }
    }
    return ignoredTypes

By default it returns empty splice.

[druminski]

👍

[coveralls]

Coverage increased (+0.2%) to 79.276% when pulling 05376d4 on blacklisted-healthcheck-types into f4d4a70 on develop.

[coveralls]

Coverage increased (+0.2%) to 79.206% when pulling 0285ada on blacklisted-healthcheck-types into f4d4a70 on develop.

[janisz]

LGTM 👍