Fixes #108 | Bounds checking for port index #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janisz
changed the title
janisz
force-pushed
the
fixes/out_of_bounds_error
branch
from
c602dbe to
8e44a71
Compare
medzin
reviewed
Dec 1, 2016
| @@ -348,6 +349,15 @@ func (c *Consul) marathonToConsulChecks(task *apps.Task, healthChecks []apps.Hea | |||
| return checks | |||
| } | |||
|
|
|||
| func getHealthCheckPort(check apps.HealthCheck, task apps.Task) (int, error) { | |||
| if check.Port != 0 { | |||
There was a problem hiding this comment.
What if check.Port will be a negative integer?
There was a problem hiding this comment.
Nothing, we will try to register it int consul. If this fail we will log error.
There was a problem hiding this comment.
IMO you should reject invalid health check port definition.
janisz
force-pushed
the
fixes/out_of_bounds_error
branch
from
8e44a71 to
3f3afc5
Compare
This was referenced Feb 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.