-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix consul curl issue on Travis #162
Conversation
e21a227
to
5be5917
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I left one comment I beleive will fix this PR (here is the source travis-ci/travis-ci#7131 (comment)). Would you mind fix it and squash commits? I'll be happy to merge it then.
@@ -1,4 +1,5 @@ | |||
language: go | |||
dist: trusty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need
sudo: false
dist: trusty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build made it much further, but hit another error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It passed for me after adding sudo line https://travis-ci.org/allegro/marathon-consul/builds/195645241
6623d0d
to
16de2b8
Compare
@mhamann Would you like to update this PR? |
Will do a bit later today. Thanks! |
For some reason build hangs. Maybe we should update consul to 7.3 |
The build hang seems to be intermittent. I did bump Consul to 0.7.3, but does not seem to have alleviated the problem. Something is flaky... |
Testing a possible fix for the curl issue.