Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consul curl issue on Travis #162

Merged
merged 2 commits into from
Jan 29, 2017
Merged

Conversation

mhamann
Copy link
Contributor

@mhamann mhamann commented Jan 26, 2017

Testing a possible fix for the curl issue.

@mhamann mhamann closed this Jan 26, 2017
@mhamann mhamann reopened this Jan 26, 2017
Copy link
Contributor

@janisz janisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I left one comment I beleive will fix this PR (here is the source travis-ci/travis-ci#7131 (comment)). Would you mind fix it and squash commits? I'll be happy to merge it then.

@@ -1,4 +1,5 @@
language: go
dist: trusty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need

sudo: false
dist: trusty

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build made it much further, but hit another error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passed for me after adding sudo line https://travis-ci.org/allegro/marathon-consul/builds/195645241

@janisz
Copy link
Contributor

janisz commented Jan 28, 2017

@mhamann Would you like to update this PR?

@mhamann
Copy link
Contributor Author

mhamann commented Jan 28, 2017

Will do a bit later today. Thanks!

@mhamann mhamann closed this Jan 28, 2017
@mhamann mhamann reopened this Jan 28, 2017
@janisz
Copy link
Contributor

janisz commented Jan 28, 2017

For some reason build hangs. Maybe we should update consul to 7.3

@mhamann
Copy link
Contributor Author

mhamann commented Jan 29, 2017

The build hang seems to be intermittent. I did bump Consul to 0.7.3, but does not seem to have alleviated the problem.

Something is flaky...

@janisz janisz merged commit 965c030 into allegro:master Jan 29, 2017
@janisz
Copy link
Contributor

janisz commented Jan 29, 2017

@mhamann Thanks!
We will try to solve flaky tests in separated PR #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants