Replace `[]*Tasks` with `[]Tasks` #192

janisz · 2017-02-28T16:00:48Z

Task is small object (112 bytes) mostly pointers (4 strings and 2 arrays).
There is no reason for using []*Tasks in Marathon response.

Refs: #190 (comment)

coveralls · 2017-02-28T16:10:54Z

Coverage decreased (-0.4%) to 90.625% when pulling c7ea2f5 on find_tasks into 14fcb04 on master.

wendigo

LGTM

Task is small object (112 bytes) mostly pointers (4 strings and 2 arrays). Tere is no reason for using `[]*Tasks` in Marathon response. Refs: #190 (comment)

coveralls · 2017-03-02T09:42:59Z

Coverage decreased (-0.4%) to 90.625% when pulling 288ce4e on find_tasks into 1cf3a1c on master.

janisz changed the title ~~Find tasks~~ Replace []*Tasks with []Tasks Feb 28, 2017

janisz mentioned this pull request Feb 28, 2017

Recheck if service should be deregistered #190

Merged

wendigo approved these changes Mar 2, 2017

View reviewed changes

Change []*Tasks to []Tasks

288ce4e

Task is small object (112 bytes) mostly pointers (4 strings and 2 arrays). Tere is no reason for using `[]*Tasks` in Marathon response. Refs: #190 (comment)

janisz force-pushed the find_tasks branch from c7ea2f5 to 288ce4e Compare March 2, 2017 09:36

janisz merged commit bb2478e into master Mar 2, 2017

janisz deleted the find_tasks branch March 2, 2017 09:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace `[]*Tasks` with `[]Tasks` #192

Replace `[]*Tasks` with `[]Tasks` #192

janisz commented Feb 28, 2017 •

edited

Loading

coveralls commented Feb 28, 2017

wendigo left a comment

coveralls commented Mar 2, 2017

Replace []*Tasks with []Tasks #192

Replace []*Tasks with []Tasks #192

Conversation

janisz commented Feb 28, 2017 • edited Loading

coveralls commented Feb 28, 2017

wendigo left a comment

Choose a reason for hiding this comment

coveralls commented Mar 2, 2017

Replace `[]*Tasks` with `[]Tasks` #192

Replace `[]*Tasks` with `[]Tasks` #192

janisz commented Feb 28, 2017 •

edited

Loading