Disable Leader detection with a '*' #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janisz
suggested changes
May 19, 2017
README.md
Outdated
| @@ -215,7 +215,7 @@ marathon-protocol | `http` | Marathon protocol (http or https | |||
| marathon-ssl-verify | `true` | Verify certificates when connecting via SSL | |||
| marathon-timeout | `30s` | Time limit for requests made by the Marathon HTTP client. A Timeout of zero means no timeout | |||
| marathon-username | | Marathon username for basic auth | |||
| marathon-leader | | Marathon cluster-wide node name (defaults to <hostname>:8080), the some leader specific calls will be made only if the specified node is the current Marathon-leader") | |||
| marathon-leader | `<hostname>:8080` | Marathon cluster-wide node name, the some leader specific calls will be made only if the specified node is the current Marathon-leader. Set to `*` to always act like a Leader. | |||
There was a problem hiding this comment.
This part of readme is copied from config/config.go could you update description there too? We should make it autogenerated.
There was a problem hiding this comment.
I understand why there is no value for "default"
janisz
approved these changes
May 22, 2017
tomez
approved these changes
May 22, 2017
|
@guilhem Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful if you always have only 1 instance running (think of
marathon-consulas a marathon app ;) ) and marathon address is provided by consul DNS.Do we missed something?