ACL token passing integration test #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://travis-ci.org/allegro/marathon-consul/builds/289041586#L2073 |
janisz
suggested changes
Oct 17, 2017
consul/consul_test_server.go
Outdated
|
|
||
| server, err := testutil.NewTestServerConfig(func(c *testutil.TestServerConfig) { | ||
| c.Datacenter = fmt.Sprint("dc-", time.Now().UnixNano()) | ||
| c.Ports = &testutil.TestPortConfig{ |
There was a problem hiding this comment.
Can you extract this to a fucntion that returns *testutil.TestPortConfig
consul/consul_test.go
Outdated
| @@ -1057,3 +1057,51 @@ func Test_substituteEnvironment(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestACLTokenPassing(t *testing.T) { | |||
There was a problem hiding this comment.
Change name of this tests to define what happens here. e.g., TestIfTokenIsUsedToConnectToConsul
There was a problem hiding this comment.
Changed to TestTokenIsUsedToConnectToConsul
chemicL
force-pushed
the
acl_token_test
branch
from
e2c348f to
a755249
Compare
chemicL
force-pushed
the
acl_token_test
branch
from
a755249 to
659a702
Compare
janisz
approved these changes
Oct 17, 2017
|
@chemicL Thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ACL token passing has been carried over from the forked project, but it had no tests.
I added an integration test, which proves the functionality works as expected.