Fix CI #17
Merged
Fix CI #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't worked with GitHub workflows before - seems like there may also need to be changes to the Docker config, for the linux build at least? |
|
Against all expectations this change is sufficient to make CI work for both Mac and Linux :) Ready for reivew. |
Seems like these were never updated previously. Sadly GitHub workflow badges don't support showing the results of individual jobs (eg. see https://github.saobby.my.eu.orgmunity/t/separate-workflow-badges-when-using-matrix-testing-possible/16708)
|
Added one more change to update the badge. After the CI workflow completes this PR is ready submit from my pov. |
|
Gentle ping :) I'm fairly sure that once this workflow runs both PRs will be in a position to merge. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like GitHub workflow build farm can't support Swift < 5.5.
https://github.com/allegro/swift-junit/runs/5063641988?check_suite_focus=true