Added escaping of error messages in the 'messages' attribute #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…failure' and 'error' tags
Without escaping of the error message, invalid XML can be generated that will fail to parse. An example would be a quote character (") was included in the error message.
ar4s
approved these changes
Jul 5, 2019
vi4m
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without escaping of the error message, invalid XML can be generated that will fail to parse. An example would be a quote character (") was included in the error message.
NOTE: I added a dependency to the HTMLString library to provide functionality for the escaping, as it's non-trivial. If this is undesired, I can manually add a local function for some of the standard possibilities, but of course, it won't be as complete.