Fixed dimensions drag and drop behaviour in Firefox (#119)

allegro · May 16, 2018 · d2bbce4 · d2bbce4
1 parent 4294d14
commit d2bbce4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/src/client/components/dimension-list-tile/dimension-list-tile.tsx b/src/client/components/dimension-list-tile/dimension-list-tile.tsx
@@ -84,8 +84,9 @@ export class DimensionListTile extends React.Component<DimensionListTileProps, D
   }
 
   dragStart(dimension: Dimension, e: DragEvent) {
-    var dataTransfer = e.dataTransfer;
+    const dataTransfer = e.dataTransfer;
     dataTransfer.effectAllowed = 'all';
+    dataTransfer.setData('text/plain', dimension.title);
 
     DragManager.setDragDimension(dimension, 'dimension-list-tile');
     setDragGhost(dataTransfer, dimension.title);

diff --git a/src/client/components/dimension-tile/dimension-tile.tsx b/src/client/components/dimension-tile/dimension-tile.tsx
@@ -376,6 +376,7 @@ export class DimensionTile extends React.Component<DimensionTileProps, Dimension
 
     const dataTransfer = e.dataTransfer;
     dataTransfer.effectAllowed = 'all';
+    dataTransfer.setData('text/plain', dimension.title);
 
     DragManager.setDragDimension(dimension, 'dimension-tile');
     setDragGhost(dataTransfer, dimension.title);

diff --git a/src/client/components/filter-tile/filter-tile.tsx b/src/client/components/filter-tile/filter-tile.tsx
@@ -226,6 +226,7 @@ export class FilterTile extends React.Component<FilterTileProps, FilterTileState
   dragStart(dimension: Dimension, clause: FilterClause, e: DragEvent) {
     const dataTransfer = e.dataTransfer;
     dataTransfer.effectAllowed = 'all';
+    dataTransfer.setData('text/plain', dimension.title);
 
     DragManager.setDragDimension(dimension, 'filter-tile');
 

diff --git a/src/client/components/split-tile/split-tile.tsx b/src/client/components/split-tile/split-tile.tsx
@@ -167,8 +167,9 @@ export class SplitTile extends React.Component<SplitTileProps, SplitTileState> {
   }
 
   dragStart(dimension: Dimension, split: SplitCombine, splitIndex: number, e: DragEvent) {
-    var dataTransfer = e.dataTransfer;
+    const dataTransfer = e.dataTransfer;
     dataTransfer.effectAllowed = 'all';
+    dataTransfer.setData('text/plain', dimension.title);
 
     DragManager.setDragSplit(split, 'filter-tile');
     DragManager.setDragDimension(dimension, 'filter-tile');