Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split on boolean dimension has string kind #563

Closed
adrianmroz opened this issue Jan 28, 2020 · 2 comments · Fixed by #833
Closed

Split on boolean dimension has string kind #563

adrianmroz opened this issue Jan 28, 2020 · 2 comments · Fixed by #833
Labels
technical debt

Comments

@adrianmroz
Copy link
Collaborator

We don't have boolean kind for Splits. In result, when converting (on table) splits to filter after highlighting, we got error, because we create string filter clause instead of boolean filter clause.

Question is - do we need different kind for splits or additional information about underlying dimension type?
@adrianmroz adrianmroz mentioned this issue Jan 28, 2020
Merged
@mkuthan
Copy link
Member

mkuthan commented Jan 30, 2020

I would define boolean specific split. Good place to change to disable "limit" for boolean splits. Right now you can set limit to 50 for boolean dims :D

@adrianmroz
Copy link
Collaborator Author

Linked #472

@adrianmroz-allegro adrianmroz-allegro mentioned this issue Feb 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new Split kind: boolean. allegro/turnilo
3 participants
@mkuthan @adrianmroz @adrianmroz-allegro