-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/highlight on base viz #564
Conversation
@@ -71,7 +71,7 @@ export const DimensionActions: React.SFC<DimensionActionsProps> = (props: Dimens | |||
|
|||
const hasSplitOn = splits.hasSplitOn(dimension); | |||
const isOnlySplit = splits.length() === 1 && hasSplitOn; | |||
const isStringDimension = dimension.kind === "string"; | |||
const isPinable = dimension.kind === "string" || dimension.kind === "boolean"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Is it feasible to define isPinable property/function inside dimension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinnable type class would be ideal. I don't like idea that dimension knows anything about "pin" action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, but I would encapsulate "string" and "boolean" at least, e.g dimension.isString dimension.isBoolean
src/client/visualizations/base-visualization/base-visualization.tsx
Outdated
Show resolved
Hide resolved
src/client/visualizations/base-visualization/base-visualization.tsx
Outdated
Show resolved
Hide resolved
src/client/visualizations/base-visualization/base-visualization.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌵
Closes #532