Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/highlight on base viz #564

Merged
merged 13 commits into from
Feb 11, 2020
Merged

Conversation

adrianmroz
Copy link
Collaborator

@adrianmroz adrianmroz commented Jan 28, 2020

Closes #532

cypress/integration/line-chart.spec.js Show resolved Hide resolved
@@ -71,7 +71,7 @@ export const DimensionActions: React.SFC<DimensionActionsProps> = (props: Dimens

const hasSplitOn = splits.hasSplitOn(dimension);
const isOnlySplit = splits.length() === 1 && hasSplitOn;
const isStringDimension = dimension.kind === "string";
const isPinable = dimension.kind === "string" || dimension.kind === "boolean";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Is it feasible to define isPinable property/function inside dimension?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinnable type class would be ideal. I don't like idea that dimension knows anything about "pin" action.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, but I would encapsulate "string" and "boolean" at least, e.g dimension.isString dimension.isBoolean

src/client/visualizations/base-visualization/highlight.ts Outdated Show resolved Hide resolved
src/client/visualizations/line-chart/line-chart.tsx Outdated Show resolved Hide resolved
Copy link

@erykpiast erykpiast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌵

src/client/visualizations/bar-chart/bar-chart.tsx Outdated Show resolved Hide resolved
cypress/integration/table.spec.js Outdated Show resolved Hide resolved
cypress/integration/table.spec.js Outdated Show resolved Hide resolved
@adrianmroz adrianmroz merged commit 2ed409e into master Feb 11, 2020
@adrianmroz adrianmroz deleted the feature/highlight-on-base-viz branch February 11, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify Highlight
4 participants