Bugfix/1.9.0 fixes #220
Merged
Bugfix/1.9.0 fixes #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkuthan
reviewed
Nov 5, 2018
| @@ -753,7 +753,7 @@ export class LineChart extends BaseVisualization<LineChartState> { | |||
| } | |||
|
|
|||
| getDatasetXRange(dataset: Dataset, continuousDimension: Dimension): PlywoodRange { | |||
| if (!dataset) return null; | |||
| if (!dataset || dataset.data.length === 0) return null; | |||
There was a problem hiding this comment.
could we use dataset.count() instead of chain of properties?
mkuthan
reviewed
Nov 5, 2018
| @@ -62,6 +62,7 @@ const numberSplitConversion: SplitDefinitionConversion<NumberSplitDefinition> = | |||
| toSplitCombine(split: NumberSplitDefinition): Split { | |||
| const { dimension, limit, sort, granularity } = split; | |||
| return new Split({ | |||
| type: SplitType.number, | |||
There was a problem hiding this comment.
Is it feasible to enhance split definition tests to cover this change?
There was a problem hiding this comment.
It's covered via viewDefinition converter, which are failing right now. I'm on it.
There was a problem hiding this comment.
OTOH, I'm thinking about overriding Split constructor, so you need provide all fields - no default values.
mkuthan
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.