Make dropdown menu scrollable #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. Give me few days (I'm involved in different project right now) to test it and I'll merge if everything will be ok. |
|
@adrianmroz I hope your project is going well. When approximately would you have time to take a look? 😅 |
|
Sorry! Project turned into vacation and here we are. I'll look into this today! |
alexmorten
added a commit
to remerge/turnilo
that referenced
this pull request
Jul 28, 2020
alexmorten
added a commit
to remerge/turnilo
that referenced
this pull request
Jul 28, 2020
…-incomplete-upstream-cherry-pick give dropdown max-height, scroll on overflow (allegro#648)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For us at remerge, the list of measures in the operand-select-dropdown is so long, that is doesn't fit on the screen anymore.
This PR limits the height of the dropdown and makes it scrollable.
This seems like the simplest solution to this, what do you think?