Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query decorator #686

Merged
merged 10 commits into from
Dec 9, 2020
Merged

query decorator #686

merged 10 commits into from
Dec 9, 2020

Conversation

adrianmroz
Copy link
Collaborator

@adrianmroz adrianmroz commented Dec 5, 2020

Closes #680
Closes #676

Copy link
Member

@mkuthan mkuthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation is missing.

@adrianmroz adrianmroz requested a review from mkuthan December 7, 2020 15:52
@adrianmroz
Copy link
Collaborator Author

Documentation is missing.

Pushed some docs

…lly uses a lot of `instanceof` operator so we need to ensure that plugin uses the same version of library.
Copy link
Contributor

@piter75 piter75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor documentation comments with request decorator function name correction being the most important one.

Co-authored-by: Piotr Szczepanik <piter75@gmail.com>

## Plugins

Most powerful way to extend turnilo are plugins. They are defined at top level in config and apply for whole Turnilo application.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If "most powerful" then put plugins at the top :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With great power comes great responsibility :)

Copy link
Member

@mkuthan mkuthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful docs, thanks!

@adrianmroz adrianmroz merged commit a19fff8 into master Dec 9, 2020
@adrianmroz adrianmroz deleted the feature/query-decorator branch December 9, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decorator for Plywood queries Documentation for plugins
4 participants