-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: consider user selected timezone while exporting the reports #707
fix: consider user selected timezone while exporting the reports #707
Conversation
79532d4
to
62f82c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very picky when it comes to naming constants :)
We will discuss internally if we want this change, give us some time.
FYI:
|
problem: Time in CSV exported reports are always in UTC timezone irrespective of user selected timezone in the UI. There are use case when time in the exported reports should be other timezone than UTC. fix: plywood passes the user selected timezone to format function here https://github.com/implydata/plywood/blob/master/src/datatypes/dataset.ts#L343 We can use that to get time in the user selected timezone. The time in reports will also have information about timezone because of ISO format.
62f82c0
to
2d6e191
Compare
Used this format because before it used to return |
Sorry, I put this comment here for fellow reviewers, so they can see what output your change would produce :) But have you tried importing this format into excel? Does excel/google sheets correctly parse this format? |
Yes, google sheet correctly parse this format |
problem:
Time in CSV exported reports are always in UTC timezone irrespective of user
selected timezone in the UI. There are use case when time in the exported
reports should be other timezone than UTC.
fix:
plywood passes the user selected timezone to format function here
https://github.com/implydata/plywood/blob/master/src/datatypes/dataset.ts#L343
We can use that to get time in the user selected timezone. The time in reports
will also have information about timezone because of ISO format.