Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup AppSettings #739

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Cleanup AppSettings #739

merged 2 commits into from
Apr 29, 2021

Conversation

adrianmroz-allegro
Copy link
Contributor

No description provided.

Copy link
Member

@mkuthan mkuthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too large to review but in general looks good :)

* Write Oauth settings object using new patterns

* Rename imported function

* Better error message
@adrianmroz-allegro adrianmroz-allegro merged commit 4754142 into master Apr 29, 2021
@adrianmroz-allegro adrianmroz-allegro deleted the feature/settings branch April 29, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants