Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Tiles #780

Merged
merged 11 commits into from
Jul 2, 2021
Merged

Commits on Jun 29, 2021

  1. Configuration menu
    Copy the full SHA
    b761667 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1254d11 View commit details
    Browse the repository at this point in the history
  3. PartialTilesProvider for keeping state of partial tiles and providing…

    … accessors and setters.
    
    Bunch of renames follows.
    adrianmroz-allegro committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    1f57c13 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. Configuration menu
    Copy the full SHA
    bc9582b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ac2fc6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7a172ac View commit details
    Browse the repository at this point in the history
  4. Refactor FilterTiles just like SeriesTiles.

    * FilterTilesRow is responsible for handling interactions (mostly drag'n' drop) and decorating callbacks from PartialTileProvider
    * FilterTiles just renders correct tiles. It handles overflow Tile and possible PartialFilter
    * FilterTile and PartialTilerTile are just visual components. They use WithRef to correctly render Menus below.
    adrianmroz-allegro committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    db18548 View commit details
    Browse the repository at this point in the history
  5. FilterMenus do not use clicker directly but accept saveClause callbac…

    …k. That also simplifies some logic in validation - no need to check whole filter, just current clause.
    
    Caveat:  TimeFilterMenu still uses Clicker to change time shift. Something to improve in the future.
    adrianmroz-allegro committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    b0b110a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a98552c View commit details
    Browse the repository at this point in the history
  7. Due to correct calculation of maxItems, all tiles from spec fit into …

    …row, so we should not to look for overflow tile.
    adrianmroz-allegro committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    e7dacea View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. Configuration menu
    Copy the full SHA
    f74080e View commit details
    Browse the repository at this point in the history