Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/timeattribute #823

Merged
merged 7 commits into from
Feb 2, 2022
Merged

Bug/timeattribute #823

merged 7 commits into from
Feb 2, 2022

Commits on Feb 1, 2022

  1. Add helpers for getting time dimension from DataCube. Now timeAttribu… 

    …te is a required property.
    @adrianmroz-allegro
    adrianmroz-allegro committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    4cd3da7 View commit details
    Browse the repository at this point in the history

  2. Use real time dimension and its reference instead of relying on the f… 

    …act that name of time attribute is equal to name of time dimension.
    @adrianmroz-allegro
    adrianmroz-allegro committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    f1b0ffe View commit details
    Browse the repository at this point in the history

  3. TimeAttribute is required so we always print it.

    @adrianmroz-allegro
    adrianmroz-allegro committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    9c6e9fc View commit details
    Browse the repository at this point in the history

  4. More strict checks for Cluster object

    @adrianmroz-allegro
    adrianmroz-allegro committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    d6731ef View commit details
    Browse the repository at this point in the history

  5. Strict checks around timeAttribute

    @adrianmroz-allegro
    adrianmroz-allegro committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    b18276a View commit details
    Browse the repository at this point in the history

  6. TimeAttribute is attribute name so use it to find dimension first and… 

    … then use dimension reference in fresh default filter
    @adrianmroz-allegro
    adrianmroz-allegro committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    e7c8de6 View commit details
    Browse the repository at this point in the history

  7. Add better warnings for missing timeAttribute property

    @adrianmroz-allegro
    adrianmroz-allegro committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    48add25 View commit details
    Browse the repository at this point in the history