Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moment's dead code elimination #864

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Moment's dead code elimination #864

merged 2 commits into from
Mar 7, 2022

Conversation

plesiecki
Copy link
Collaborator

@plesiecki plesiecki commented Mar 4, 2022 •
edited
Loading

@plesiecki plesiecki mentioned this pull request Mar 4, 2022
Open
12 tasks
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646407087990-13800.report.html

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

✅ Deployed successfully to: https://turnilo-moment-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

github-actions bot commented Mar 4, 2022 •
edited
Loading

size-limit report 📦

Path Size
build/public/main.js 1.94 MB (-11.55% 🔽)

@plesiecki plesiecki marked this pull request as ready for review March 4, 2022 16:03
adrianmroz-allegro
adrianmroz-allegro approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@adrianmroz-allegro adrianmroz-allegro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible that we would need to revert it for #504 but I don't think we even know how we will format time. Maybe Intl will be common till then.

@github-actions
Copy link

github-actions bot commented Mar 5, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646507980788-29084.report.html

@github-actions
Copy link

github-actions bot commented Mar 5, 2022

✅ Deployed successfully to: https://turnilo-moment-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

github-actions bot commented Mar 5, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646508184383-8262.report.html

@github-actions
Copy link

github-actions bot commented Mar 5, 2022

✅ Deployed successfully to: https://turnilo-moment-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

github-actions bot commented Mar 5, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646508412945-96614.report.html

@github-actions
Copy link

github-actions bot commented Mar 5, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646508464049-21582.report.html

@github-actions
Copy link

github-actions bot commented Mar 5, 2022

✅ Deployed successfully to: https://turnilo-moment-gmbbyye42a-ew.a.run.app

@plesiecki plesiecki changed the title Exclude locale from moment Moment's dead code elimination Mar 5, 2022
@github-actions
Copy link

github-actions bot commented Mar 5, 2022

✅ Deployed successfully to: https://turnilo-moment-gmbbyye42a-ew.a.run.app

mkuthan
mkuthan reviewed Mar 7, 2022
View reviewed changes
Copy link
Member

@mkuthan mkuthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it is a safe change. See https://allegro.github.io/turnilo/configuration-customizations.html#timezones

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646646522999-54491.report.html

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

✅ Deployed successfully to: https://turnilo-moment-gmbbyye42a-ew.a.run.app

@plesiecki plesiecki merged commit 1e8ff03 into master Mar 7, 2022
@plesiecki plesiecki deleted the moment branch March 7, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkuthan mkuthan mkuthan left review comments

@adrianmroz-allegro adrianmroz-allegro adrianmroz-allegro approved these changes

@kzadurska kzadurska kzadurska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plesiecki @mkuthan @kzadurska @adrianmroz-allegro