Markdown parser lib change, snarkdown instead of marked. Build tests with babel instead of ts-node. #873

    if (!extendedDescription) {
-      return <MarkdownNode markdown={description || STRINGS.noDescription} />;
+      return <React.Suspense fallback={Loader}>


It works and how!

src/client/views/home-view/data-cube-card/data-cube-card.tsx

adrianmroz-allegro · 2022-03-08T16:19:07Z

src/client/drag-and-drop-polyfill.ts

    // @ts-ignore
-    import("../../lib/polyfill/drag-drop-polyfill.css")
+    import(/* webpackChunkName: "dnd-css" */ "../../lib/polyfill/drag-drop-polyfill.css")


I assume these comments are meaningful for webpack? Will something horribly broke if someone removes them by accident?

It sets name for new chunk, otherwise webpack chunk index number as its name. It should be good without thoes comments.

adrianmroz-allegro

Move button to Suspense boundary.

plesiecki · 2022-03-08T16:26:31Z

Move button to Suspense boundary.

Done 👍

adrianmroz-allegro

Conditional approve. Code is good, let's discuss with team if UX is acceptable.

github-actions · 2022-03-08T16:32:06Z

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646757124576-38285.report.html

github-actions · 2022-03-08T16:33:32Z

✅ Deployed successfully to: https://turnilo-marked-gmbbyye42a-ew.a.run.app

github-actions · 2022-03-08T17:19:01Z

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646759939694-92339.report.html

github-actions · 2022-03-08T17:19:45Z

✅ Deployed successfully to: https://turnilo-marked-gmbbyye42a-ew.a.run.app

github-actions · 2022-03-08T17:21:46Z

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646760105022-5819.report.html

github-actions · 2022-03-08T17:22:38Z

✅ Deployed successfully to: https://turnilo-marked-gmbbyye42a-ew.a.run.app

github-actions · 2022-03-09T07:43:13Z

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646811791646-91453.report.html

github-actions · 2022-03-09T07:44:56Z

✅ Deployed successfully to: https://turnilo-marked-gmbbyye42a-ew.a.run.app

github-actions · 2022-03-09T08:45:51Z

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646815550315-72622.report.html

github-actions · 2022-03-09T08:47:30Z

✅ Deployed successfully to: https://turnilo-marked-gmbbyye42a-ew.a.run.app

adrianmroz-allegro · 2022-03-09T09:32:51Z

test/setup/mocha.js

+    extensions: [".ts", ".tsx", ".js", ".jsx"],
+    ignore: [
+        function(filePath) {
+            return filePath.includes("node_modules") && !filePath.includes("snarkdown")


By default ignore is like [/node_modules/]. In the meantime, ESM module was imported under snarkdown and I had to treat it with a transpilation. But I re-checked this setting and it seems it's now all good without it 🤔

github-actions · 2022-03-09T09:56:07Z

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646819766033-91333.report.html

github-actions · 2022-03-09T09:57:47Z

✅ Deployed successfully to: https://turnilo-marked-gmbbyye42a-ew.a.run.app

adrianmroz-allegro

Yay!

github-actions · 2022-03-09T10:43:11Z

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646822589235-1824.report.html

github-actions · 2022-03-09T10:46:21Z

✅ Deployed successfully to: https://turnilo-marked-gmbbyye42a-ew.a.run.app

plesiecki force-pushed the marked branch from 5578860 to 6ce9c01 Compare March 8, 2022 13:51

plesiecki force-pushed the marked branch from 6ce9c01 to 2590795 Compare March 8, 2022 13:54

plesiecki force-pushed the marked branch from 2590795 to 2646e19 Compare March 8, 2022 14:11

plesiecki force-pushed the marked branch from 2646e19 to 4482a37 Compare March 8, 2022 14:27

plesiecki force-pushed the marked branch from 4482a37 to c065ab4 Compare March 8, 2022 14:33

adrianmroz-allegro reviewed Mar 8, 2022

View reviewed changes

plesiecki marked this pull request as ready for review March 8, 2022 15:33

plesiecki mentioned this pull request Mar 8, 2022

Web performance optimizations #845

Open

12 tasks

adrianmroz-allegro reviewed Mar 8, 2022

View reviewed changes

src/client/views/home-view/data-cube-card/data-cube-card.tsx Outdated Show resolved Hide resolved

adrianmroz-allegro reviewed Mar 8, 2022

View reviewed changes

adrianmroz-allegro suggested changes Mar 8, 2022

View reviewed changes

plesiecki force-pushed the marked branch from c065ab4 to a97bf34 Compare March 8, 2022 16:26

adrianmroz-allegro approved these changes Mar 8, 2022

View reviewed changes

plesiecki force-pushed the marked branch from a97bf34 to c67ff24 Compare March 8, 2022 17:13

plesiecki changed the title ~~Dynamically import markdown-node module~~ Markdown parser lib change, snarkdown instead of marked. Mar 8, 2022

Markdown parser lib change, snarkdown instead of marked.

286baf5

plesiecki force-pushed the marked branch from c67ff24 to 286baf5 Compare March 8, 2022 17:16

plesiecki force-pushed the marked branch 4 times, most recently from 882391f to 5c982f6 Compare March 9, 2022 07:39

plesiecki force-pushed the marked branch from 5c982f6 to bb83a37 Compare March 9, 2022 08:41

adrianmroz-allegro reviewed Mar 9, 2022

View reviewed changes

plesiecki force-pushed the marked branch from bb83a37 to f80a2db Compare March 9, 2022 09:52

adrianmroz-allegro approved these changes Mar 9, 2022

View reviewed changes

babel/register instead of ts-node

c6d9e43

plesiecki force-pushed the marked branch from f80a2db to c6d9e43 Compare March 9, 2022 10:38

plesiecki merged commit 795774b into master Mar 9, 2022

plesiecki deleted the marked branch March 9, 2022 11:13

plesiecki added the technical debt label Mar 9, 2022

plesiecki changed the title ~~Markdown parser lib change, snarkdown instead of marked.~~ Markdown parser lib change, snarkdown instead of marked. Build tests with babel instead of ts-node. Mar 9, 2022

Markdown parser lib change, snarkdown instead of marked. Build tests with babel instead of ts-node. #873

Markdown parser lib change, snarkdown instead of marked. Build tests with babel instead of ts-node. #873

Conversation

plesiecki commented Mar 8, 2022 • edited Loading

github-actions bot commented Mar 8, 2022 • edited Loading

size-limit report 📦

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

adrianmroz-allegro Mar 8, 2022

Choose a reason for hiding this comment

plesiecki Mar 8, 2022

Choose a reason for hiding this comment

adrianmroz-allegro Mar 8, 2022

Choose a reason for hiding this comment

plesiecki Mar 8, 2022 • edited Loading

Choose a reason for hiding this comment

adrianmroz-allegro left a comment

Choose a reason for hiding this comment

plesiecki commented Mar 8, 2022

adrianmroz-allegro left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 9, 2022

github-actions bot commented Mar 9, 2022

github-actions bot commented Mar 9, 2022

github-actions bot commented Mar 9, 2022

adrianmroz-allegro Mar 9, 2022

Choose a reason for hiding this comment

plesiecki Mar 9, 2022

Choose a reason for hiding this comment

github-actions bot commented Mar 9, 2022

github-actions bot commented Mar 9, 2022

adrianmroz-allegro left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 9, 2022

github-actions bot commented Mar 9, 2022

plesiecki commented Mar 8, 2022 •

edited

Loading

github-actions bot commented Mar 8, 2022 •

edited

Loading

plesiecki Mar 8, 2022 •

edited

Loading