Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split visualizations into chunks #875

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Split visualizations into chunks #875

merged 2 commits into from
Mar 10, 2022

Conversation

plesiecki
Copy link
Collaborator

@plesiecki plesiecki commented Mar 9, 2022 •
edited
Loading

@github-actions
Copy link

github-actions bot commented Mar 9, 2022 •
edited
Loading

size-limit report 📦

Path Size
build/public/main.js 1.71 MB (-8.46% 🔽)
build/public/polyfills.es5.js 42.74 KB (+0.48% 🔺)
build/public/dnd.es5.js 4.61 KB (+0.13% 🔺)

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646847289802-46830.report.html

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

✅ Deployed successfully to: https://turnilo-visualization-chunks-gmbbyye42a-ew.a.run.app

@plesiecki plesiecki force-pushed the visualization-chunks branch from 8360f76 to cd23084 Compare March 9, 2022 17:52
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646848558067-67416.report.html

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

✅ Deployed successfully to: https://turnilo-visualization-chunks-gmbbyye42a-ew.a.run.app

@plesiecki plesiecki mentioned this pull request Mar 9, 2022
Open
12 tasks
@plesiecki plesiecki force-pushed the visualization-chunks branch from cd23084 to 796cb88 Compare March 9, 2022 18:58
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646852606257-54039.report.html

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

✅ Deployed successfully to: https://turnilo-visualization-chunks-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646852967982-19317.report.html

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646865589542-32310.report.html

@github-actions
Copy link

⏱️ Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1646913570577-7234.report.html

@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-visualization-chunks-gmbbyye42a-ew.a.run.app

mkuthan
mkuthan reviewed Mar 10, 2022
View reviewed changes
Copy link
Member

@mkuthan mkuthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected more changes from splitting visualisations

@plesiecki plesiecki merged commit 6d4cef8 into master Mar 10, 2022
@plesiecki plesiecki deleted the visualization-chunks branch March 10, 2022 12:26
l2dy
l2dy reviewed Mar 14, 2022
View reviewed changes
config/webpack.prod.js
@@ -53,7 +53,16 @@ const prodConfig = {
'process.env.NODE_ENV': JSON.stringify('production')
}),
],
stats: 'minimal'
optimization: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate optimization key, see line 47.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l2dy l2dy l2dy left review comments

@mkuthan mkuthan mkuthan left review comments

@adrianmroz-allegro adrianmroz-allegro adrianmroz-allegro approved these changes

Assignees
No one assigned
Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plesiecki @mkuthan @l2dy @adrianmroz-allegro