Chart colors improvements #918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
| "#B0B510", | ||
| "#904064" | ||
| ]; | ||
| export const NORMAL_COLORS = Object.values(styles); |
There was a problem hiding this comment.
Order is important here, let's map on static key names.
| export type ColorScale = d3.ScaleLinear<string, string>; | ||
|
|
||
| const white = "#fff"; | ||
| const orange = "#ff5a00"; | ||
| const orange = styles.orange; |
There was a problem hiding this comment.
I'm wondering if should we have additional "brand" colour that's somehow customisable. In Allegro case of course it would be orange and we should set orange as default.
| @include css-variable(fill, item-dimension); | ||
| // @include css-variable(stroke, brand); | ||
| // @include css-variable(fill, item-dimension); | ||
| stroke: $orange; |
There was a problem hiding this comment.
Same thing with "brand" colour.
| // @include css-variable(stroke, brand); | ||
| // @include css-variable(fill, item-dimension); | ||
| stroke: $orange; | ||
| fill: lighten($orange, 25%); |
There was a problem hiding this comment.
That's iffy. But to be honest previous code was also iffy.
| @@ -112,7 +112,7 @@ describe("Split adjustment utilities", () => { | |||
| }); | |||
|
|
|||
| describe("adjustColorSplit", () => { | |||
| it("should adjust limit with predefined limits (5, 10)", () => { | |||
| it("should adjust limit with predefined limits (5, 10)", () => { // THIS FAILS | |||
There was a problem hiding this comment.
That's ... surprising to say at least :o
|
Closed in favour of #955 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What would happen if we had visualization colors in CSS? It would work, but not in the unit tests 😬