Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on the latest Node 14.x and 16.x #956

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Build on the latest Node 14.x and 16.x #956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8465c2
Build on the latest Node 14.x and 16.x
mkuthan Nov 23, 2022
4943fc6
Get rid of "captain obvious" warning about versions.
mkuthan Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Setup build
inputs:
node-version:
required: true
default: '16.15.0'
default: '16'
description: Node version

runs:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:

strategy:
matrix:
node-version: [14.20.0, 16.15.0]
node-version: ['14', '16']

steps:
- uses: actions/checkout@v3
Expand All @@ -40,7 +40,7 @@ jobs:

strategy:
matrix:
node-version: [14.20.0, 16.15.0]
node-version: ['14', '16']

steps:
- uses: actions/checkout@v3
Expand Down
3 changes: 1 addition & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
#
# BUILD stage
# Use last supported node version (16.15.0) for build
#
FROM node:16.15.0 AS build
FROM node:16 AS build

WORKDIR /usr/src/app

Expand Down
3 changes: 0 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ or join the chat on [Slack](https://join.slack.com/t/turnilo/shared_invite/enQtO

* [Node.js](https://nodejs.org/) - 14.x or 16.x version

:warning:
We test builds with 14.20.0 and 16.15.0

:warning:
Do not use `yarn` command for dependency management and project build, use `npm` instead.
With `npm` builds are reproducible (thanks to package-lock.json) and even faster than with `yarn`.
Expand Down