Health endpoint verifies Druid brokers' health and readiness #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkuthan
reviewed
Apr 19, 2018
docs/health-checking.md
Outdated
|
|
||
| It can be checked by sending a GET request to a `healthEndpoint` path defined in Turnilo's server [configuration](configuration.md). | ||
|
|
||
| Healthy Turnilo instance responds with HTTP status 200 while an unhealthy one responds with the status of 500. |
There was a problem hiding this comment.
I would return 503 as a more specific error.
src/common/models/cluster/cluster.ts
Outdated
| @@ -82,6 +84,7 @@ function ensureNotTiny(v: number): void { | |||
| export class Cluster extends BaseImmutable<ClusterValue, ClusterJS> { | |||
| static TYPE_VALUES: SupportedType[] = ['druid', 'mysql', 'postgres']; | |||
| static DEFAULT_TIMEOUT = 40000; | |||
| static DEFAULT_HEALTH_CHECKING_TIMEOUT = 1000; | |||
There was a problem hiding this comment.
There is no continuous form in other configuration properties. So I would use default_health_check_timeout.
src/server/routes/health/health.ts
Outdated
| const unhealthyHttpStatus = 500; | ||
| const healthyHttpStatus = 200; | ||
|
|
||
| type ClusterHealthStatus = typeof healthyStatus | typeof unhealthyStatus; |
mkuthan
approved these changes
Apr 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82