Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel dataset verification bug in master fails on older versions of Python #1144

Closed
charlienewey-odin opened this issue Oct 25, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@charlienewey-odin
Copy link
Contributor

charlienewey-odin commented Oct 25, 2023

Describe the bug

A recent commit to dataset verification in dataset.py has introduced a Python version incompatibility.

This is the commit that introduced the bug: f964783

The problem is on this line

The cancel_futures argument was not introduced until Python 3.9 - see Python docs here: https://docs.python.org/3/library/concurrent.futures.html#concurrent.futures.Executor.shutdown. This renders clearml incompatible with many of the versions advertised in the README.

This bug should not have been able to find its way into master. Do ClearML have tox tests or similar?

To reproduce

Validate a dataset with Python <= 3.8.

@charlienewey-odin charlienewey-odin added the bug Something isn't working label Oct 25, 2023
@eugen-ajechiloae-clearml
Copy link
Collaborator

Hi @charlienewey-odin ! We already have a fix for this which will be synced with Github soon. Note that this shouldn't have made it to an official release

@pollfly
Copy link
Contributor

pollfly commented Nov 14, 2023

Hey @charlienewey-odin! Just letting you know that this issue has been resolved in the recently released v1.13.2. Let us know if there are any issues :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants