Fix issue #1249 pytorch-lightning patches #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue \ discussion
See #1249.
Patch Description
This patch adds more precise error handling and recovery for attribute errors encountered when accessing module or class attributes whose existence depends upon the version of
pytorch-lightninginstalled.The patch also deduplicates some code between
PatchPyTorchModelIO._patch_lightning_ioandPatchPyTorchModelIO._patch_pytorch_lightning_io.Testing Instructions
Without the patch applied, train a model with
pytorch-lightning-2.0.0or greater and save a checkpoint, which should automatically be uploaded to the ClearML server if the task is configured to do so.Trying to resume training from the checkpoint will not work as the patch for loading models cannot be applied.
With the patch applied, training should resume as expected.
Other Information