Make dataset preview optional. #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkhenning
reviewed
May 31, 2024
| @@ -655,10 +656,13 @@ def upload( | |||
| - 1: if the upload destination is a cloud provider ('s3', 'gs', 'azure') | |||
| - number of logical cores: otherwise | |||
| :param int retries: Number of retries before failing to upload each zip. If 0, the upload is not retried. | |||
| :param preview: If True (defaul) the dataset preview is uploaded and shown in the UI. | |||
There was a problem hiding this comment.
Please just change typo (default) 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue \ discussion
#1227
Patch Description
Make dataset preview in the UI optional.