fix for local file uploads without scheme #1326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he absolute path for the file in such cases and use it as source url
| if base_url != 'file://': | ||
| return remote_url | ||
| absoulte_path = os.path.abspath(remote_url) | ||
| return base_url + absoulte_path |
There was a problem hiding this comment.
Note that, in case a user adds a file that is already prefixed with file://, the os.path.abspath(remote_url) will return an unexpected value. For example:
>>> os.path.abspath("file:///home/ajecc/work")
'/home/ajecc/file:/home/ajecc/work'
I suggest checking if the remote_url already starts with file://, in which case you don't need to add the base_url
There was a problem hiding this comment.
Thanks for getting it @eugen-ajechiloae-clearml . Sorry i missed this case. Updated the code and tested it.
There was a problem hiding this comment.
Hi @eugen-ajechiloae-clearml , please review this change once when you get the time.
added 4 commits
September 18, 2024 20:55
…he absolute path for the file in such cases and use it as source url
… into fix-local-file-uploads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue on scenario where local file path is provided without scheme in add_external_file functionality.
Related Issue \ discussion
Fix for #1313
Patch Description
If the file added has a local path, the absolute path is fetched and the 'file://' scheme is added.
Testing Instructions
Described in [#1313]
Other Information
Tested file addition using absolute path, relative path and remote path. File addition and upload is working fine.
I could only test for Windows system.