Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground access for unsupported devices #156

Merged
merged 12 commits into from
Feb 5, 2025

Conversation

jonryser
Copy link
Collaborator

@jonryser jonryser commented Feb 5, 2025

Describe the changes

  • (Stanley) added WebView to OLMoE playground.
  • (Stanley) updated UnsupportedDeviceView text.
  • (Jon) Added line break in content in Unsupported Device View.
  • (Jon) Vertically centered Unsupported Device View.

iPhone:
Simulator Screenshot - iPhone 16 - 2025-02-04 at 21 55 14
Simulator Screenshot - iPhone 16 - 2025-02-04 at 17 50 43

iPad:
Simulator Screenshot - iPad Pro 13-inch (M4) - 2025-02-04 at 21 57 50
Simulator Screenshot - iPad Pro 13-inch (M4) - 2025-02-05 at 08 51 13

Checklist before requesting a review

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have tested my changes and ensured that they work as expected.
  • I have updated examples and documentation as necessary.

Copy link
Collaborator

@Stanley-Jovel Stanley-Jovel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.
We may need to add a button to open on a web browser

Copy link
Collaborator

@Stanley-Jovel Stanley-Jovel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it! though I left one more comment

@jonryser jonryser merged commit 79e16f3 into develop Feb 5, 2025
1 check passed
@jonryser jonryser deleted the playground-access-for-unsupported-devices branch February 5, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants