Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9 sharing disclaimer pop up #26

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

Stanley-Jovel
Copy link
Collaborator

What does this PR do

  • Show disclaimer pop up before sharing
  • Add spinner indicator when sharing
  • Create new constants folder
  • Move Disclaimer page content into constants folder

Issue

#9

Demo

Screen.Recording.2024-11-14.at.12.35.49.PM.mov

Add spinner indicator when sharing

Create new constants folder

Move Disclaimer page content into constants folder
@Stanley-Jovel Stanley-Jovel self-assigned this Nov 14, 2024
Copy link
Collaborator

@ThomasJones ThomasJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Stanley-Jovel Stanley-Jovel merged commit cac1702 into release-20241118 Nov 14, 2024
1 check passed
@Stanley-Jovel Stanley-Jovel deleted the 9-sharing-disclaimer-pop-up branch November 14, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants